From b8ae21eebc2644b4115cbbc007d8a483f369af37 Mon Sep 17 00:00:00 2001
From: zeus <zeus@ctdo.de>
Date: Sun, 11 Sep 2022 18:29:51 +0200
Subject: [PATCH] corrected minor errors

---
 openscad/foreign/sc808/io-shield.scad | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/openscad/foreign/sc808/io-shield.scad b/openscad/foreign/sc808/io-shield.scad
index 4487732..bce589b 100644
--- a/openscad/foreign/sc808/io-shield.scad
+++ b/openscad/foreign/sc808/io-shield.scad
@@ -7,7 +7,7 @@ mt=2;
 q=0.01; //used as variable to remove manifold-glitches in preview. can be set to "0" in final version
 $fn=100;
 // shield:
-shield_w=178; // let's hope that fits onto my delta...
+shield_w=177.5; // let's hope that fits onto my delta...
 shield_h=41;
 shield_d=10; //around 11.5 in the original, but that is not needed
 shield_tab_emboss_d=1; // that lowered lip, that the central and outer tabs mounts onto, 1mm (or one sheet-thickness) lower than the rest
@@ -30,7 +30,7 @@ m_gril_spacing=m_gril_w;
 // MODEL:
 // mounting holes around the shield perimeter
 module shield_hole(x,y,z,rotx,roty){
-    translate([x,y,shield_d/2-z])rotate([rotx,roty,0])#cylinder(d1=shield_hole_d1,d2=shield_hole_d2,h=mt+q,center=true);
+    translate([x,y,shield_d/2-z])rotate([rotx,roty,0])cylinder(d1=shield_hole_d1,d2=shield_hole_d2,h=mt+q,center=true);
 }
 // basic shield
 module shield(){
@@ -44,15 +44,15 @@ module shield(){
             // some holes all around, (left, than clockwise, viewed from behind) 
             // shield_hole(x,y,z,rotx,roty), "z" is the distance from lip-edge to the center of the hole, x is from center
             shield_hole(-shield_w/2+mt/2,-0.5,4,0,-90); //left side
-            shield_hole(-shield_w/2+mt/2+6,shield_h/2-shield_tab_emboss_d-mt/2-q*0.5,6.25,-90,0); //top side, 1st from left (recessed)
-            shield_hole(-shield_w/2+mt/2+30.5,shield_h/2-mt/2,4.4,-90,0); //top side, 2nd from left
+            #shield_hole(-shield_w/2+mt/2+4.5,shield_h/2-shield_tab_emboss_d-mt/2-q*0.5,6.25,-90,0); //top side, 1st from left (recessed)
+            shield_hole(-shield_w/2+mt/2+29.5,shield_h/2-mt/2,4.4,-90,0); //top side, 2nd from left 
             shield_hole(-shield_w/2+mt/2+148.5,shield_h/2-mt/2,4.4,-90,0); //top side, 3rd from left
             shield_hole(-shield_w/2+mt/2+162,shield_h/2-shield_tab_emboss_d-mt/2-q*0.5,5.5,-90,0); //top side, 4th from left (recessed)
             shield_hole(-shield_w/2+mt/2+173,shield_h/2-shield_tab_emboss_d-mt/2-q*0.5,6.25,-90,0); //top side, 5th from left (recessed)
-            shield_hole(shield_w/2-mt/2,-0.5,4,0,90); //right side
+            shield_hole(shield_w/2-mt/2,-0.5,4,0,90); //right side ok
             shield_hole(-shield_w/2+mt/2+173,-shield_h/2+mt/2,4.25,90,0); // bottom side, 1st one from right
-            shield_hole(-shield_w/2+mt/2+57.75,-shield_h/2+mt/2,4.25,90,0); //bottom side, 2nd one from right
-            shield_hole(-shield_w/2+mt/2+6,-shield_h/2+mt/2,4.25,90,0); //bottom side, 3rd one from right
+            shield_hole(-shield_w/2+mt/2+56.25,-shield_h/2+mt/2,4.25,90,0); //bottom side, 2nd one from right
+            shield_hole(-shield_w/2+mt/2+4.5,-shield_h/2+mt/2,4.25,90,0); //bottom side, 3rd one from right
         }
   }
         for(x=[-shield_w/2+shield_tab_emboss_l/2+mt/2,shield_w/2-shield_tab_emboss_l/2-mt/2]){ // tab-cutout support-structure
@@ -95,7 +95,9 @@ difference(){
 
 
 
-
+// todo: 
+// shield holes durchgängig
+// seitlicher tab hinzufügen, loch beachten!